HADOOP-17229. No updation of bytes received counter value after response failure occurs in ABFS by mehakmeet · Pull Request #2264 · apache/hadoop

mehakmeet · 2020-09-01T11:22:37Z

After a response failure at the moment, there is an increment to the bytes_received counter value which shouldn't increment.

Test-run: mvn -T 1C -Dparallel-tests=abfs clean verify

[INFO] Results:
[INFO]
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0

[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemCheckAccess.<init>:82->setTestUserFs:104 » IllegalArgument
[ERROR]   ITestAzureBlobFileSystemDelete.testDeleteIdempotencyTriggerHttp404:223 » NoSuchField
[ERROR]   ITestAzureBlobFileSystemRename.testRenameIdempotencyTriggerHttpNotFound:225->testRenameIdempotencyTriggerChecks:236 » NoSuchField
[INFO]
[ERROR] Tests run: 452, Failures: 0, Errors: 14, Skipped: 61

[INFO] Results:
[INFO]
[WARNING] Tests run: 206, Failures: 0, Errors: 0, Skipped: 29

Not really sure about these two failures, seeing these in trunk as well.

[ERROR]   ITestAzureBlobFileSystemDelete.testDeleteIdempotencyTriggerHttp404:223 » NoSuchField
[ERROR]   ITestAzureBlobFileSystemRename.testRenameIdempotencyTriggerHttpNotFound:225->testRenameIdempotencyTriggerChecks:236 » NoSuchField

Others are already in a Jira: HADOOP-17203.

…nse failure occurs in ABFS

hadoop-yetus · 2020-09-01T12:34:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	29m 17s	trunk passed
+1 💚	compile	0m 36s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 33s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 27s	trunk passed
+1 💚	mvnsite	0m 39s	trunk passed
+1 💚	shadedclient	15m 14s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 30s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 28s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	0m 57s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 55s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 29s	the patch passed
+1 💚	compile	0m 28s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	0m 28s	the patch passed
+1 💚	compile	0m 24s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	0m 24s	the patch passed
+1 💚	checkstyle	0m 17s	the patch passed
+1 💚	mvnsite	0m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 55s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 25s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 24s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	0m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 28s	hadoop-azure in the patch passed.
-1 ❌	asflicense	0m 33s	The patch generated 3 ASF License warnings.
		71m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/1/artifact/out/Dockerfile
GITHUB PR	#2264
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f5e23bb11dfd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7e671f3`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/1/testReport/
asflicense	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count	413 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

...ols/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java

steveloughran · 2020-09-02T12:27:20Z

LGTM, one minor change which is only count 200 responses, so as to make clear it is only successful GETs which are measured

mehakmeet · 2020-09-02T12:33:29Z

I was testing after the single-line comment, turns out the read() method is returning the bytes with HTTP-206(Partial Content) status code. So, should I check for only 206 for incrementing?

hadoop-yetus · 2020-09-03T14:47:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	31m 52s	trunk passed
+1 💚	compile	0m 33s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 30s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 22s	trunk passed
+1 💚	mvnsite	0m 33s	trunk passed
+1 💚	shadedclient	16m 39s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 26s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 24s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	0m 55s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 53s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 29s	the patch passed
+1 💚	compile	0m 28s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	0m 28s	the patch passed
+1 💚	compile	0m 24s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	0m 24s	the patch passed
-0 ⚠️	checkstyle	0m 15s	hadoop-tools/hadoop-azure: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	mvnsite	0m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 35s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 22s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 20s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	0m 55s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 22s	hadoop-azure in the patch passed.
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		76m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/2/artifact/out/Dockerfile
GITHUB PR	#2264
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f46c16aa3b96 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `288dab7`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/2/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/2/testReport/
Max. process+thread count	308 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

steveloughran · 2020-09-03T17:54:12Z

This is better. These are the only two responses which constitute success, right?

mehakmeet · 2020-09-03T17:59:46Z

It'd be from 200 to 206, so 7 in total. While testing I saw 206 was the code when there were some bytes returned. Not so sure about the other 2XX codes, but 200 and 202 were giving success with 0 bytes returned in a read() op.

hadoop-yetus · 2020-09-03T18:45:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	41m 49s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	35m 20s	trunk passed
+1 💚	compile	0m 40s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 34s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 25s	trunk passed
+1 💚	mvnsite	0m 41s	trunk passed
+1 💚	shadedclient	19m 0s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 31s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 30s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	1m 5s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 3s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 34s	the patch passed
+1 💚	compile	0m 35s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	0m 35s	the patch passed
+1 💚	compile	0m 29s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	0m 29s	the patch passed
+1 💚	checkstyle	0m 20s	the patch passed
+1 💚	mvnsite	0m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	17m 23s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 26s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 23s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	1m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 32s	hadoop-azure in the patch passed.
+1 💚	asflicense	0m 36s	The patch does not generate ASF License warnings.
		126m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/3/artifact/out/Dockerfile
GITHUB PR	#2264
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux cf5228b9e205 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5c15815`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/3/testReport/
Max. process+thread count	414 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2264/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

steveloughran · 2020-09-08T09:14:44Z

+1, merged to trunk, do a retest on branch-3.3 and I'll merge there too

…nse failure occurs in ABFS (apache#2264) Contributed by Mehakmeet Singh

…e failure occurs in ABFS (#2264) Contributed by Mehakmeet Singh Change-Id: Ia9ad1b87a460b10d27486bd00ee67c3cedd2b5b5

…nse failure occurs in ABFS (apache#2264) Contributed by Mehakmeet Singh (cherry picked from commit 0d85515)

…fter response failure occurs in ABFS (apache#2264) Contributed by Mehakmeet Singh ""Only flaky failures / known issues found. For details see the Quanta runs triaged."" Change-Id: Iabfa88dbde2d1e15375389b020225a51d49a7379

HADOOP-17229. No updation of bytes recevied counter value after respo…

ae68665

…nse failure occurs in ABFS

steveloughran reviewed Sep 2, 2020

View reviewed changes

...ols/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java Outdated Show resolved Hide resolved

HADOOP-17229. Increment condition change

888dca3

mehakmeet requested a review from steveloughran September 3, 2020 13:29

HADOOP-17229. checkstyle fix

ac32ffc

steveloughran merged commit 0d85515 into apache:trunk Sep 8, 2020

mehakmeet added a commit to mehakmeet/hadoop that referenced this pull request Sep 8, 2020

HADOOP-17229. No updation of bytes received counter value after respo…

5e89292

…nse failure occurs in ABFS (apache#2264) Contributed by Mehakmeet Singh

mehakmeet mentioned this pull request Sep 8, 2020

HADOOP-17229. No updation of bytes received counter value after response failure occurs in ABFS #2283

Closed

asfgit pushed a commit that referenced this pull request Sep 8, 2020

HADOOP-17229. No update of bytes received counter value after respons…

7970710

…e failure occurs in ABFS (#2264) Contributed by Mehakmeet Singh Change-Id: Ia9ad1b87a460b10d27486bd00ee67c3cedd2b5b5

arjun4084346 pushed a commit to arjun4084346/hadoop that referenced this pull request Apr 30, 2022

HADOOP-17229. No updation of bytes received counter value after respo…

ad21360

…nse failure occurs in ABFS (apache#2264) Contributed by Mehakmeet Singh (cherry picked from commit 0d85515)

arjun4084346 mentioned this pull request Apr 30, 2022

HADOOP-17229. No updation of bytes received counter value after respo… arjun4084346/hadoop#5

Open

4 tasks

arjun4084346 pushed a commit to arjun4084346/hadoop that referenced this pull request Apr 30, 2022

HADOOP-17229. No updation of bytes received counter value after respo…

b669cc7

…nse failure occurs in ABFS (apache#2264) Contributed by Mehakmeet Singh (cherry picked from commit 0d85515)

arjun4084346 pushed a commit to arjun4084346/hadoop that referenced this pull request May 3, 2022

HADOOP-17229. No updation of bytes received counter value after respo…

75a398d

…nse failure occurs in ABFS (apache#2264) Contributed by Mehakmeet Singh (cherry picked from commit 0d85515)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-17229. No updation of bytes received counter value after response failure occurs in ABFS#2264

HADOOP-17229. No updation of bytes received counter value after response failure occurs in ABFS#2264
steveloughran merged 3 commits intoapache:trunkfrom
mehakmeet:HADOOP-17229

mehakmeet commented Sep 1, 2020 •

edited

Loading

Uh oh!

hadoop-yetus commented Sep 1, 2020

Uh oh!

Uh oh!

steveloughran commented Sep 2, 2020

Uh oh!

mehakmeet commented Sep 2, 2020

Uh oh!

hadoop-yetus commented Sep 3, 2020

Uh oh!

steveloughran commented Sep 3, 2020

Uh oh!

mehakmeet commented Sep 3, 2020

Uh oh!

hadoop-yetus commented Sep 3, 2020

Uh oh!

steveloughran commented Sep 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mehakmeet commented Sep 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadoop-yetus commented Sep 1, 2020

Uh oh!

Uh oh!

steveloughran commented Sep 2, 2020

Uh oh!

mehakmeet commented Sep 2, 2020

Uh oh!

hadoop-yetus commented Sep 3, 2020

Uh oh!

steveloughran commented Sep 3, 2020

Uh oh!

mehakmeet commented Sep 3, 2020

Uh oh!

hadoop-yetus commented Sep 3, 2020

Uh oh!

steveloughran commented Sep 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mehakmeet commented Sep 1, 2020 •

edited

Loading